Gdprice sdk v1#597
Merged
Merged
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Reintroduction of problematic RPC endpoint ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| src/hooks/useWeb3.tsx | ✅ |
| src/pages/gd/Swap/SwapCelo/UniSwap.tsx | ✅ |
| src/connectors/index.ts | ✅ |
| src/pages/gd/Portfolio/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @sirpy - I've reviewed your changes - here's some feedback:
- The file:.yalc override for @gooddollar/web3sdk isn’t a published version—please revert this before merging or switch to the proper package version.
- Adding
gdPriceto the usePromise dependency list will re‐fetch on every price tick—ensure this is intended or consider debouncing/memoizing to avoid excessive calls. - The UniSwap Celo RPC change uses forno despite the existing comment about gas issues—either validate this endpoint’s reliability or update/remove the stale comment.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| 42220: [ | ||
| // 'https://forno.celo.org', // forno is causing gas issues with uniswap | ||
| 'https://rpc.ankr.com/celo', | ||
| 'https://forno.celo.org', |
There was a problem hiding this comment.
issue: Outdated comment about forno causing gas issues remains
Please update or remove the outdated comment referencing gas issues with forno, as it no longer reflects the current implementation.
L03TJ3
approved these changes
May 22, 2025
L03TJ3
left a comment
L03TJ3
left a comment
Collaborator
There was a problem hiding this comment.
Just update to latest sdk-v1 once that PR is merged
Deploying goodprotocolui with
|
| Latest commit: |
7518da6
|
| Status: | ⚡️ Build in progress... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pass down the gdprice from the new celo reserve
Description by Korbit AI
What change is being made?
Upgrade the
@gooddollar/web3sdkto version 0.1.50,@gooddollar/web3sdk-v2to version 0.4.13, switch the default CELO RPC endpoint from 'https://rpc.ankr.com/celo' to 'https://forno.celo.org', and integrateuseG$Pricewithin the portfolio page.Why are these changes being made?
The SDK versions needed to be updated to incorporate the latest fixes and features. Switching to 'https://forno.celo.org' provides a more reliable CELO RPC provider, addressing previous connectivity issues. The addition of
useG$Priceinto the portfolio is to dynamically fetch and utilize the current GoodDollar price, enhancing the application's functionality and user experience.