Custom Select Picker Layouts v2#960
Open
LeaVerou wants to merge 2 commits into
Open
Conversation
5d01580 to
5b0acae
Compare
Collaborator
Author
|
@rviscomi ping! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands the content of this guide and addresses some of the issues I flagged here:
Changes related to the review issues:
:opento code snippets and explicitly instruct agents to respect it (current guidance produced broken UI)Other changes:
valueattributes on options to the general best practices for customizable select.