fix: group clicks in action #3052
Merged
+186
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
force-pushed
the
sadym/dblclick-test
branch
2 times, most recently
from
83a7dcf to
e41ab46
Compare
sadym-chromium
force-pushed
the
sadym/dblclick-test
branch
from
9d374ea to
aaed398
Compare
sadym-chromium
changed the title
OrKoN
approved these changes
Jan 31, 2025
| */ | ||
| resetClickCount(): void { | ||
| this.#clickContexts = new Map< | ||
| number, |
There was a problem hiding this comment.
Nit: you can just write :
this.#clickContexts = new Map()
There was a problem hiding this comment.
Double nit: this.#clickContexts.clear()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address #3043.
Group clicks only in a single
input.performActions.