fix: removing request size limit - #231
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the custom gRPC maximum receive message size configuration (previously set to 10 MB) and its associated import. The reviewer points out that removing this option entirely reverts the gRPC client to its default 4 MB limit, which could lead to failures if responses exceed this size. The reviewer suggests explicitly setting the limit to the maximum possible value (math.MaxInt32) and restoring/adding the necessary imports.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request increases the gRPC maximum send and receive message sizes to 100 MB in the Bigtable client manager. Feedback points out that Cloud Bigtable enforces a strict server-side limit of 40 MB per request, so setting the client's maximum send size to 100 MB is misleading and should be reduced to 40 MB to align with the service limits.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the gRPC client options in bigtable_client_manager.go to increase the maximum send and receive message sizes to 256 MB (using 1<<28). The feedback suggests defining this hardcoded limit as a named constant to improve code readability and recommends making it configurable via the proxy configuration.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the gRPC client configuration in bigtable_client_manager.go to increase the maximum message send and receive sizes to math.MaxInt32, aligning them with server-side limits. I have no feedback to provide as there are no review comments.
64ae040 to
690dcac
Compare
Set the GRPC request size limit to max so the Bigtable server can enforce it instead.