Skip to content

fix: removing request size limit - #231

Merged
annguy3n merged 1 commit into
GoogleCloudPlatform:mainfrom
brandtnewton:proxy/remove-request-size-limit
Jul 28, 2026
Merged

fix: removing request size limit#231
annguy3n merged 1 commit into
GoogleCloudPlatform:mainfrom
brandtnewton:proxy/remove-request-size-limit

Conversation

@brandtnewton

@brandtnewton brandtnewton commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Set the GRPC request size limit to max so the Bigtable server can enforce it instead.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the custom gRPC maximum receive message size configuration (previously set to 10 MB) and its associated import. The reviewer points out that removing this option entirely reverts the gRPC client to its default 4 MB limit, which could lead to failures if responses exceed this size. The reviewer suggests explicitly setting the limit to the maximum possible value (math.MaxInt32) and restoring/adding the necessary imports.

@brandtnewton

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the gRPC maximum send and receive message sizes to 100 MB in the Bigtable client manager. Feedback points out that Cloud Bigtable enforces a strict server-side limit of 40 MB per request, so setting the client's maximum send size to 100 MB is misleading and should be reduced to 40 MB to align with the service limits.

@brandtnewton

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gRPC client options in bigtable_client_manager.go to increase the maximum send and receive message sizes to 256 MB (using 1<<28). The feedback suggests defining this hardcoded limit as a named constant to improve code readability and recommends making it configurable via the proxy configuration.

@brandtnewton

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gRPC client configuration in bigtable_client_manager.go to increase the maximum message send and receive sizes to math.MaxInt32, aligning them with server-side limits. I have no feedback to provide as there are no review comments.

@brandtnewton
brandtnewton force-pushed the proxy/remove-request-size-limit branch from 64ae040 to 690dcac Compare July 28, 2026 18:45
@annguy3n
annguy3n self-requested a review July 28, 2026 19:50
@annguy3n
annguy3n merged commit 5ab671c into GoogleCloudPlatform:main Jul 28, 2026
7 checks passed
@release-please release-please Bot mentioned this pull request Jul 28, 2026
@brandtnewton
brandtnewton deleted the proxy/remove-request-size-limit branch July 28, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants