Introduce Hns and Flat strategy and integrate with GcsFileSystem - #311
Open
suni72 wants to merge 23 commits into
Open
Introduce Hns and Flat strategy and integrate with GcsFileSystem#311suni72 wants to merge 23 commits into
suni72 wants to merge 23 commits into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a bucket capabilities caching layer and namespace strategy resolution to support Hierarchical Namespace (HNS) routing and optimization. Key changes include adding BucketCapabilities, defining NamespaceStrategy with flat and hierarchical implementations, and integrating a Caffeine-backed cache with TTL in AnalyticsCacheManager. Feedback focuses on improving encapsulation and API design, specifically by removing testing-only methods from the public GcsFileSystem interface, making internal methods package-private, converting BucketCapabilities to an @AutoValue class, and simplifying a lambda expression to a method reference.
suni72
force-pushed
the
dir-metadata-ops-2
branch
3 times, most recently
from
June 24, 2026 10:55
c507032 to
c58a027
Compare
suni72
force-pushed
the
dir-metadata-ops-2
branch
10 times, most recently
from
July 10, 2026 12:52
70c1223 to
98f664d
Compare
suni72
marked this pull request as ready for review
July 10, 2026 13:04
dheerajsngh
reviewed
Jul 13, 2026
dheerajsngh
reviewed
Jul 13, 2026
dheerajsngh
reviewed
Jul 13, 2026
dheerajsngh
reviewed
Jul 13, 2026
dheerajsngh
reviewed
Jul 13, 2026
…spaceStrategy interface
suni72
marked this pull request as draft
July 28, 2026 06:32
…ent.isHnsBucket method
…ectory and listing operations
suni72
marked this pull request as ready for review
July 29, 2026 10:46
dheerajsngh
reviewed
Jul 30, 2026
dheerajsngh
reviewed
Jul 30, 2026
dheerajsngh
reviewed
Jul 30, 2026
dheerajsngh
reviewed
Jul 30, 2026
dheerajsngh
reviewed
Jul 30, 2026
dheerajsngh
reviewed
Jul 30, 2026
dheerajsngh
reviewed
Jul 30, 2026
dheerajsngh
reviewed
Jul 30, 2026
- rename HNS configuration key to hierarchical.namespace.enable - Update test names for clarity - Reverted unrelated changes in FakeGcsFileSystemImpl Updated tests to use constants instead of hardcoded strings
dheerajsngh
reviewed
Aug 4, 2026
dheerajsngh
reviewed
Aug 4, 2026
dheerajsngh
reviewed
Aug 4, 2026
dheerajsngh
reviewed
Aug 4, 2026
dheerajsngh
reviewed
Aug 4, 2026
dheerajsngh
left a comment
dheerajsngh
left a comment
Contributor
There was a problem hiding this comment.
Added some comments. PTAL
Other things look good.
dheerajsngh
self-requested a review
August 4, 2026 05:31
…follow AAA structure
…resolution in GcsFileSystemImpl
dheerajsngh
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
feat: A new featurefix: A bug fixdocs: Documentation only changesstyle: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)refactor: A code change that neither fixes a bug nor adds a featureperf: A code change that improves performancetest: Adding missing tests or correcting existing testschore: Changes to the build process or auxiliary tools and libraries such as documentation generationDescription
What?
NamespaceStrategyinterface alongsideFlatNamespaceStrategyImplandHierarchicalNamespaceStrategyImplimplementations.GcsFileSystemImplto integrate NamespaceStrategy based on bucket HNS configuration and HNS API enable flag in core.GcsFileSystemOptionsto configure HNS API usage.Why?
Dynamically routes folder commands based on the bucket's namespace configuration (flat vs. hierarchical).
Checklist
feat(core): ...)Generated/Assisted by Agent? [Yes/No]