Merge main into epic/issue-285-api-client-v2 - #312
Closed
kyasbal wants to merge 4 commits into
Closed
Conversation
* feat(server): Add ServerFactory type to configure the gin.Engine instance easier in the initialization phase Several KHI feature sometimes needs to register API handler on gin.Engine but it was difficult before. This makes the initialization code under cmd/kubernetes-history-inspector harder. This change introduced a new type ServerFactory used for instancing a new gin.Engine instance. This type receives Option parameters to extend the server instance. This allows user to extend its behavior just by adding new init() function on cmd/kubernetes-history-inspector or each task package folders. * fix points pointed out by gemini-code-review
* fix lint related minor issues * exclude *.go files under `**/test` folder to be evaluated by "no-testutil-in-non-test-files" rule. * Use non containerlized golangci-lint when it's available to run them faster. * fix issues pointed by gemini-code-assist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are already reviewed when these were merged into main branch, thus I'll skip review requirement.