Merge main into epic/issue-373

[kyasbal]

These changes are approved on the main branch. I'll skip reviews before the merge.

[gemini-code-assist]

Summary of Changes

Hello @kyasbal, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates changes from the main branch into the epic/issue-373 branch, primarily focusing on enhancing the flexibility and dynamism of Cloud Logging resource name inputs. It introduces a new task labeling system to allow tasks to declare their need for optional resource names, and refactors the input handling mechanism to actively query the task graph for these requirements. This ensures that the user interface for resource name overrides is always aligned with the currently active tasks.

Highlights

• Dynamic Resource Name Input: Introduced a new mechanism to dynamically identify tasks that require optional Cloud Logging resource name inputs by labeling them, enhancing flexibility in task configuration.
• New Task Label: Added RequestOptionalInputResourceNameTaskLabel to mark tasks that need resource name inputs, allowing the system to query the active task graph for these requirements.
• Refactored Resource Name Input Task: The InputLoggingFilterResourceNameTask was updated to retrieve active resource name requests directly from the task graph, replacing a static method for gathering these inputs.
• Code Cleanup: Removed the GetQueryResourceNamePairs function from resourcename.go as its functionality is now handled by the dynamic task graph inspection.
• Typo Correction: Fixed a minor typo from 'charactors' to 'characters' in a logging warning message within listlogentries_task.go.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the mechanism for handling optional resource name inputs for logging queries. Instead of relying on a statically accumulated list of queries, it now dynamically discovers active tasks requiring resource names from the task graph using labels. This is a good improvement for correctness and maintainability.

I've found one potential issue regarding duplicate query IDs that could lead to UI bugs, and I've suggested a fix. I've also recommended an additional test case to cover this scenario.

[gemini-code-assist]

The current implementation may return duplicate query IDs if multiple active tasks use the same ID. This could lead to duplicate form fields in the UI, which is confusing for the user.

To prevent this, it's better to use a map to collect unique query IDs. Sorting the result also ensures a deterministic order, which improves UI consistency and testability.

Please also add import "sort" to the file.

	tasks := runner.Tasks()
	queryIDSet := make(map[string]struct{})
	for _, t := range tasks {
		if requestInput, found := typedmap.Get(t.Labels(), googlecloudcommon_contract.RequestOptionalInputResourceNameTaskLabel); found {
			queryIDSet[requestInput] = struct{}{}
		}
	}
	result := make([]string, 0, len(queryIDSet))
	for queryID := range queryIDSet {
		result = append(result, queryID)
	}
	sort.Strings(result)
	return result

[gemini-code-assist]

It's good practice to also test the case where multiple tasks might have the same query ID. This would highlight the need for deduplication in getCurrentActiveQueryIDsForResourceName and verify the fix is working as expected.

	t1 := coretask.NewTask(taskid.NewDefaultImplementationID[struct{}]("t1"), nil, nil, coretask.WithLabelValue(
		googlecloudcommon_contract.RequestOptionalInputResourceNameTaskLabel, "test1",
	))
	t2 := coretask.NewTask(taskid.NewDefaultImplementationID[struct{}]("t2"), nil, nil, coretask.WithLabelValue(
		googlecloudcommon_contract.RequestOptionalInputResourceNameTaskLabel, "test2",
	))
	t1Dup := coretask.NewTask(taskid.NewDefaultImplementationID[struct{}]("t1-dup"), nil, nil, coretask.WithLabelValue(
		googlecloudcommon_contract.RequestOptionalInputResourceNameTaskLabel, "test1",
	))
	nonRelatedTask := coretask.NewTask(taskid.NewDefaultImplementationID[struct{}]("not-related"), nil, nil)
	testCases := []struct {
		desc  string
		tasks []coretask.UntypedTask
		want  []string
	}{
		{
			desc:  "with mixed tasks",
			tasks: []coretask.UntypedTask{t1, t2, nonRelatedTask},
			want: []string{
				"test1",
				"test2",
			},
		},
		{
			desc:  "with duplicate query IDs",
			tasks: []coretask.UntypedTask{t1, t2, t1Dup, nonRelatedTask},
			want: []string{
				"test1",
				"test2",
			},
		},
		{
			desc:  "with no tasks",
			tasks: []coretask.UntypedTask{},
			want:  []string{},
		},
	}