refactor(composer): refine Airflow timeline styles and path hierarchy - #871
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the timeline path and style definitions for Google Cloud Composer / Airflow. It replaces the project-level timeline hierarchy with a root-level Airflow timeline, simplifies component timeline creation, and updates various timeline types and styles. Additionally, it removes the unnecessary dependency on ClusterIdentityTaskID across multiple mappers. The review feedback highlights that several timeline styles use raw style.Color with manual float values, which is inconsistent with the codebase and can lead to incorrect color rendering on the UI. It is recommended to use style.MustForceConvertSRGBHex instead to ensure proper color space conversion.
kyasbal
marked this pull request as ready for review
August 6, 2026 03:01
kyasbal
requested review from
K53,
RyuSA,
jyane,
kkuchima and
renamoo
as code owners
August 6, 2026 03:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the Airflow/Cloud Composer timeline hierarchy and updated timeline styling properties (icons, colors, priorities, and sort policies) to improve visual clarity on the UI. Also removed redundant GCP Project ID parameters from timeline path builders.
Key Changes
1. Timeline Styling and Registration
pkg/task/inspection/googlecloudclustercomposer/contract/timeline_type.go:AlphabeticalSortPolicy,ChronologicalSortPolicy) for Airflow timelines (TimelineTypeAirflowDAG,TimelineTypeAirflowDAGRun,TimelineTypeAirflowTaskInstance, etc.).2. Timeline Path Hierarchy Simplification
pkg/task/inspection/googlecloudclustercomposer/contract/timeline_path.go:MustComposerEnvironmentTimelinewithMustAirflowTimeline, removing the unnecessary GCP Project ID parameter.MustAirflowComponentTimeline.DAG files(MustAirflowDAGFilesTimeline).3. Mapper Implementations and Test Updates
TimelinePathhelpers, removing unusedClusterIdentityTaskIDdependencies:pkg/task/inspection/googlecloudclustercomposer/impl/dag_processor_manager_mapper.gopkg/task/inspection/googlecloudclustercomposer/impl/scheduler.gopkg/task/inspection/googlecloudclustercomposer/impl/worker.gopkg/task/inspection/googlecloudclustercomposer/impl/other.goVerification
go test ./pkg/task/inspection/googlecloudclustercomposer/...