fixed Composer parser bugs - #873
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the ComposerWorkerTaskInstanceFieldSetReader by introducing a helper struct workerTaskInstanceInfo and helper methods readLabels and parsePayload to parse and merge task instance information from labels and text payloads. It also adds corresponding unit tests. The review feedback points out that parsePayload silently ignores errors from stringToTiState using blank identifiers. To prevent silent failures, it is recommended to propagate these errors by updating parsePayload to return an error, handling it in Read, and updating the test cases accordingly.
kyasbal
force-pushed
the
push-lppkwxszlvto
branch
from
August 6, 2026 08:00
a4a8d73 to
37e691b
Compare
kyasbal
marked this pull request as ready for review
August 6, 2026 08:08
kyasbal
requested review from
K53,
RyuSA,
jyane,
kkuchima and
renamoo
as code owners
August 6, 2026 08:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Airflow log parser wrongly returned STATUS_NONE for some particular logs.
This PR fixes the issues and adding tests.