Add key_revocation_action_type field to google_compute_instance and related resources
#11741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
melinath
requested review from
a team,
melinath and
rileykarson
and removed request for
melinath and
a team
|
reassigning due to upcoming OOO |
|
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label |
add region_instance_template Add key_revocation_action_type field
c2thorn
force-pushed
the
key-revocation-action-field
branch
from
37e2089
to
8c1e296
Compare
modular-magician
added
service/compute-instances
and removed
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
Tests were added that are skipped in VCR:
View the build log |
modular-magician
added
the
awaiting-approval
|
@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label |
modular-magician
removed
the
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_instance" "primary" {
key_revocation_action_type = # value needed
}
Resource: resource "google_compute_instance_from_machine_image" "primary" {
key_revocation_action_type = # value needed
}
Resource: resource "google_compute_instance_from_template" "primary" {
key_revocation_action_type = # value needed
}
Resource: resource "google_compute_instance_template" "primary" {
key_revocation_action_type = # value needed
}
Resource: resource "google_compute_region_instance_template" "primary" {
key_revocation_action_type = # value needed
}
|
Tests analyticsTotal tests: 1028 Click here to see the affected service packages
Action takenFound 342 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Co-authored-by: Cameron Thornton <[email protected]>
…for logging resource `LogScope` (GoogleCloudPlatform#11882)
…oogleCloudPlatform#11827) Co-authored-by: Nick Elliot <[email protected]>
…gleCloudPlatform#11770) Co-authored-by: Zhenhua Li <[email protected]>
…kfill Pipeline Jobs for Healthcare Data Engine (GoogleCloudPlatform#11812) Co-authored-by: Cameron Thornton <[email protected]>
…tform#11885) Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…terraform_attribution_label` and `terraform_attribution_label_addition_strategy` (GoogleCloudPlatform#11884)
…oogle_secret_manager_secrets` datasource (GoogleCloudPlatform#11904)
|
needed a rebase and broke the branch :D. Will reopen but all the fixes requested are implemented now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value should be NONE because it's set by the API automatically. There is a test case that checks if it produces any diff if the field is unset
Release Note Template for Downstream PRs (will be copied)