Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change update method for boot_disk.auto_delete on google_compute_instance #11742

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

karolgorc
Copy link
Contributor

closes hashicorp/terraform-provider-google#14707

This will prevent recreating the VM when changing auto_delete parameter

Release Note Template for Downstream PRs (will be copied)

compute: `google_compute_instance` is no longer recreated when changing `boot_disk.auto_delete`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing auto_delete on boot_disk to false wrongly triggers google_compute_instance replacement
2 participants