Fix: Interconnect fail_open field

[harshithpatte-g]

b/367757958

The schema is wrong for fail open field.
Moving it outside of the pre_shared_keys

Release Note Template for Downstream PRs (will be copied)

compute: added `macsec.fail_open` field to `google_compute_interconnect`

compute: deprecated `macsec.pre_shared_keys.fail_open` field in `google_compute_interconnect`. Use the new `macsec.fail_open` field instead

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 41 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 41 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  macsec {
    pre_shared_keys {
      fail_open = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 1005
Passed tests: 930
Skipped tests: 74
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInterconnect_computeInterconnectMacsecTest

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInterconnect_computeInterconnectMacsecTest[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[shuyama1]

Overall LGTM. Only a small nit-pick. I've also modified the changelog a bit. Please let me know if it makes sense. Thanks!

[shuyama1]

only nit-pick: we use spaces instead of tabs for indentation in resource configs. Thanks

[harshithpatte-g]

Thanks, I will update it.

[harshithpatte-g]

Overall LGTM. Only a small nit-pick. I've also modified the changelog a bit. Please let me know if it makes sense. Thanks!

Thanks! 👍

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 41 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 3 files changed, 41 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_interconnect (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_interconnect" "primary" {
  macsec {
    pre_shared_keys {
      fail_open = # value needed
    }
  }
}

[modular-magician]

Tests analytics

Total tests: 1011
Passed tests: 937
Skipped tests: 74
Affected tests: 0

Click here to see the affected service packages

• compute

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log