Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: add support for autopilot to set gcp_filestore_csi_driver_config in addons config #11748

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philipsabri
Copy link

@philipsabri philipsabri commented Sep 18, 2024

Add support for creating Autopilot Clusters with the gcp_filestore_csi_driver_config setting disabled, as supported by the API.
Explanation and API example on my comment.

Fixes hashicorp/terraform-provider-google#17215

Release Note Template for Downstream PRs (will be copied)

container: add support for manually setting `gcp_filestore_csi_driver_config` in the addons configuration for Autopilot clusters.

Copy link

google-cla bot commented Sep 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 18, 2024
@modular-magician modular-magician added service/container and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Sep 19, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 79 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 3 files changed, 79 insertions(+), 14 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 212
Passed tests: 198
Skipped tests: 13
Affected tests: 1

Click here to see the affected service packages
  • container

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerCluster_withAutopilotGcpFilestoreCsiDriver

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccContainerCluster_withAutopilotGcpFilestoreCsiDriver[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_container_cluster: with enable_autopilot does not allow configuring gcp_filestore_csi_driver_config
2 participants