Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new cloud logging resource LogScope to Terraform #11763

Merged
merged 9 commits into from
Sep 20, 2024

Conversation

tyh2333
Copy link
Contributor

@tyh2333 tyh2333 commented Sep 19, 2024

Adding a new cloud logging resource LogScope to Terraform.

  • To fully utilize logScopes, enterprise customers require Terraform tooling to set up log scopes at scale.
  • See LogScope public doc.
`google_logging_log_scope`

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 19, 2024
@tyh2333 tyh2333 marked this pull request as ready for review September 19, 2024 23:06
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/logging and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Sep 20, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 781 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 781 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 113 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_logging_log_scope (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_logging_log_scope" "primary" {
  location = # value needed
  parent   = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 77
Passed tests: 74
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages
  • logging

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccLoggingLogScope_loggingLogScopeBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccLoggingLogScope_loggingLogScopeBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Copy link
Contributor

@hao-nan-li hao-nan-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the missing fields to the existing test?

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 20, 2024
@tyh2333
Copy link
Contributor Author

tyh2333 commented Sep 20, 2024

Just added the missing fields and remove a few unused comments. Thanks !

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 20, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 787 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 787 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 113 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 77
Passed tests: 74
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages
  • logging

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccLoggingLogScope_loggingLogScopeBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccLoggingLogScope_loggingLogScopeBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants