chore(deps): update dependency google-cloud-datastore to v2.20.2 #13026
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,3 +1,3 @@ | ||||||||||
| Flask==3.0.3 | ||||||||||
| google-cloud-datastore==2.20.2 | ||||||||||
|
There was a problem hiding this comment. Consider adding a comment explaining the reason for this version bump, referencing the bug fix included in 2.20.2. This will help with future maintainability and understanding the context of the change. For example, you could add a comment like
Suggested change
There was a problem hiding this comment. Updating to 2.20.2 is a good move. To improve clarity and maintainability, consider adding an inline comment briefly explaining the reason for this specific version bump, referencing the bug fix. This helps provide context for future updates.
Suggested change
There was a problem hiding this comment. Updating There was a problem hiding this comment. Updated to There was a problem hiding this comment. Bumping the version of the There was a problem hiding this comment. Updated There was a problem hiding this comment. The dependency has been updated correctly to 2.20.2. Per PEP 8, using |
||||||||||
| gunicorn==22.0.0 | ||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,5 +1,5 @@ | ||||||||||
| Flask==3.0.3; python_version > '3.6' | ||||||||||
| Flask==2.3.3; python_version < '3.7' | ||||||||||
| google-cloud-datastore==2.20.2 | ||||||||||
|
There was a problem hiding this comment. Updating There was a problem hiding this comment. Similar to the previous suggestion, add a comment explaining the reason for updating to 2.20.2. Referencing the specific bug fix will make it easier to understand why this change was made in the future. For example, you could add a comment like
Suggested change
There was a problem hiding this comment. Updating to 2.20.2 addresses the list meaning preservation bug. A quick inline comment referencing the bug fix (#575) would be helpful for future reference.
Suggested change
There was a problem hiding this comment. Updating There was a problem hiding this comment. Updated to There was a problem hiding this comment. Bumping the version of the There was a problem hiding this comment. Updated There was a problem hiding this comment. The dependency update is correct. Consider pinning to the exact version ( |
||||||||||
| gunicorn==22.0.0 | ||||||||||
| Werkzeug==3.0.3 | ||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1 +1 @@ | ||||||||||
| google-cloud-datastore==2.20.2 | ||||||||||
|
There was a problem hiding this comment. Updating There was a problem hiding this comment. It's a good idea to add a comment explaining the reason for this version change. Specifically mentioning the bug fix will provide valuable context for anyone reviewing this file later. For example, you could add a comment like
Suggested change
There was a problem hiding this comment. Since this
Suggested change
There was a problem hiding this comment. Updating There was a problem hiding this comment. Updated to There was a problem hiding this comment. Bumping the version of the There was a problem hiding this comment. Updated There was a problem hiding this comment. The update to 2.20.2 is correct. For better control over dependency versions, consider pinning to the exact version using |
||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1 +1 @@ | ||||||||||
| google-cloud-datastore==2.20.2 | ||||||||||
|
There was a problem hiding this comment. Updating There was a problem hiding this comment. Consider adding a comment to explain why this dependency was updated to 2.20.2. Referencing the bug fix will help others understand the change and its importance. For example, you could add a comment like
Suggested change
There was a problem hiding this comment. A short comment explaining the version update would improve maintainability and provide context for others working with this code. Referencing the bug fix (#575) would be beneficial.
Suggested change
There was a problem hiding this comment. Updating There was a problem hiding this comment. Updated to There was a problem hiding this comment. Bumping the version of the There was a problem hiding this comment. Updated There was a problem hiding this comment. Correct update to 2.20.2. Consider explicitly pinning the version with |
||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,5 +1,5 @@ | ||||||||||
| google-cloud-dlp==3.25.1 | ||||||||||
| google-cloud-storage==2.9.0 | ||||||||||
| google-cloud-pubsub==2.21.5 | ||||||||||
| google-cloud-datastore==2.20.2 | ||||||||||
|
There was a problem hiding this comment. Updating There was a problem hiding this comment. Adding a comment explaining the reason for the version update is beneficial for maintainability. Mentioning the bug fix will provide context for future reviews. For example, you could add a comment like
Suggested change
There was a problem hiding this comment. To enhance readability and maintainability, consider adding a comment explaining the reason for this version update. A reference to the bug fix (#575) would be valuable.
Suggested change
There was a problem hiding this comment. Updating There was a problem hiding this comment. Updated to There was a problem hiding this comment. Bumping the version of the There was a problem hiding this comment. Updated There was a problem hiding this comment. The |
||||||||||
| google-cloud-bigquery==3.27.0 | ||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||||||
| functions-framework==3.5.0 | ||||||||||
| google-events==0.11.0 | ||||||||||
| google-cloud-datastore==2.20.2 | ||||||||||
|
There was a problem hiding this comment. Updating There was a problem hiding this comment. A comment explaining the reason for this version bump would be helpful. Specifically, referencing the bug fix will provide context for future maintainers. For example, you could add a comment like
Suggested change
There was a problem hiding this comment. Adding an inline comment explaining the reason for this version bump (and referencing the bug fix #575) would be helpful for future maintainability and provide context for anyone working with this Cloud Function.
Suggested change
There was a problem hiding this comment. Updating There was a problem hiding this comment. Updated to There was a problem hiding this comment. Bumping the version of the There was a problem hiding this comment. Updated There was a problem hiding this comment. The dependency is correctly updated to 2.20.2. It's generally a good practice to pin the dependency to a specific version using |
||||||||||
| google-api-core==2.17.1 | ||||||||||
| protobuf==4.25.5 | ||||||||||
| cloudevents==1.11.0 | ||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating
google-cloud-datastoreto 2.20.2 is recommended, per the PEP 8 style guide recommendation to keep dependencies up to date (https://peps.python.org/pep-0008/#id47). Test thoroughly after merging, focusing on list operations within the Datastore context. Add a unit test tomain_test.pyreplicating the original bug scenario (https://redirect.github.com/googleapis/python-datastore/issues/575) to prevent regressions.