feat(csql): update all v1 Cloud SQL Proxy usages to v2 #13194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
samples
|
/gcbrun |
jackwotherspoon
changed the title
|
I can see that v2 Cloud SQL Proxy is starting fine... Cloud SQL proxy started for MySQL.
Cloud SQL proxy started for Postgres.
Cloud SQL proxy started for SQL Server.
|
|
Moved back to draft, to fix tests. |
|
Cloud SQL tests are all passing now... cloud-sql/mysql/client-side-encryption................................[ SUCCESS]
cloud-sql/mysql/sqlalchemy............................................[ SUCCESS]
cloud-sql/postgres/client-side-encryption.............................[ SUCCESS]
cloud-sql/postgres/sqlalchemy.........................................[ SUCCESS]
cloud-sql/sql-server/client-side-encryption...........................[ SUCCESS]
cloud-sql/sql-server/sqlalchemy.......................................[ SUCCESS] |
jackwotherspoon
commented
Mar 3, 2025
| mountPath: /cloudsql | ||
| ports: | ||
| - containerPort: 8080 | ||
| initContainers: |
There was a problem hiding this comment.
using newer native Kubernetes sidecar pattern: https://kubernetes.io/blog/2023/08/25/native-sidecar-containers/
|
The only official docs page that is affected by this change is https://cloud.google.com/python/django/kubernetes-engine which already telling users to install the v2 Cloud SQL Proxy (partially). Will need to update one reference of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Cloud SQL Proxy v2 was released in 2022, moving test infra and usage of v1 Proxy over to v2 syntax. v1 is heading towards deprecation.
Migration guide can be referenced for guidance.
Fixes #13123