Fix regular path query test coverage #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In GraphBLAS#261 an algorithm for evaluating regular path queries has been introduced. The algorithm uses NFAs for representing regular constraints and uses transpositions of their adjacency matrices. The implementation involved checks on whether the provided adjacency matrix is symmetric and its transpositions are cached though this behavior hasn't been tested and the coverage has been lower than 100%. This patch fixes it by varying whether to cache the matrix transpositions and compute the symmetry flags.
|
The v1.2 branch is now at 100% test coverage -- thanks! I've also added a "ctest . -T memcheck" option, and it passes as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #261 an algorithm for evaluating regular path queries has been introduced. The algorithm uses NFAs for representing regular constraints and uses transpositions of their adjacency matrices. The implementation involved checks on whether the provided adjacency matrix is symmetric and its transpositions are cached though this behavior hasn't been tested and the coverage has been lower than 100%. This patch fixes it by varying whether to cache the matrix transpositions and compute the symmetry flags.