Skip to content

In the Path tool, make Space shift the anchor while dragging handles #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 26, 2024
Merged

In the Path tool, make Space shift the anchor while dragging handles #2065

merged 14 commits into from
Oct 26, 2024

Conversation

DaraghD
Copy link
Contributor

@DaraghD DaraghD commented Oct 21, 2024 •
edited
Loading

Naming probs needs some changes
Screencast_20241021_205201.webm

The points dont get highlighted until the cursor moves them, which isnt great although im not currently sure how to solve that, maybe moving them slightly back and forward or their might be some message I need to pass. This is also the case with my previous pr #2058
Partially closes #1870

@DaraghD DaraghD marked this pull request as draft October 22, 2024 07:26
@DaraghD DaraghD marked this pull request as ready for review October 22, 2024 20:05
@DaraghD
Copy link
Contributor Author

DaraghD commented Oct 22, 2024

After looking into the tasks in #1870 that involve the keybindings , I realise my way of handling input here was probably wrong, Ill redo the input handling to keep it more consistent

@DaraghD DaraghD marked this pull request as draft October 22, 2024 22:09
@DaraghD DaraghD marked this pull request as ready for review October 23, 2024 22:04
@DaraghD DaraghD force-pushed the space_selects_anchor_and_handles branch from 4b647f8 to 10ce3fb Compare October 23, 2024 22:12
@DaraghD
Copy link
Contributor Author

DaraghD commented Oct 23, 2024

Switched it around to use refresh keys, should be easy to switch it back if the other way of splitting it up into its own key entry is wanted.

@Keavon Keavon force-pushed the space_selects_anchor_and_handles branch from ea9e924 to 893d0e4 Compare October 26, 2024 07:26
@Keavon
Copy link
Member

Keavon commented Oct 26, 2024 •
edited
Loading

I found a couple edge cases that should be fixed before merging:

  1. If you drag a handle while holding Space and release the mouse before Space, it results in all the handles and anchors remaining selected instead of those which were actually selected when starting the drag.
  2. When dragging an anchor rather than a handle, Space causes one of the two handles to become temporarily selected. This behavior shouldn't have any effect whatsoever (ideally it doesn't trigger those code paths) on the anchors being dragged without any selected handles.

@Keavon Keavon mentioned this pull request Oct 26, 2024
Open
31 tasks
@DaraghD
fix: Small bugs relating to space handle selection
0f988be 
If release mouse before space, reselect previous points and unselects points
selected by space.
If only anchor is selected it will not select handles.
Removed comment as its now clear what its doing / where its coming from
@Keavon
Copy link
Member

Keavon commented Oct 26, 2024

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for 0f988be
https://df070353.graphite.pages.dev

@Keavon Keavon changed the title Space shifts the anchor (and handles) while pressed In the Path tool, make Space shift the anchor while dragging handles Oct 26, 2024
@Keavon Keavon enabled auto-merge (squash) October 26, 2024 09:14
@Keavon Keavon merged commit b1399af into GraphiteEditor:master Oct 26, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keavon Keavon Keavon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue: Pen and Path tool improvements
2 participants
@DaraghD @Keavon