Feat/issue #332 zoom buttons#86
Conversation
| font-weight: 500; | ||
| } | ||
|
|
||
| .leaflet-control-zoom.leaflet-bar { |
There was a problem hiding this comment.
this removes a broken looking offset shadow that appears around the zoom buttons
|
@pratikmdhr can you help review this PR? |
pratikmdhr
left a comment
pratikmdhr
left a comment
There was a problem hiding this comment.
@stellarjaysoftware Nice work!! apart from the comment I've made, it all looks good!
|
|
||
| this.map = this.L.map(mountTarget, mapOptions) | ||
| if (this.zoomControlPosition) { | ||
| this.map.zoomControl.setPosition(this.zoomControlPosition) |
There was a problem hiding this comment.
when this map-core is mounted to the map-client, setPosition will throw an error for the case when the zoomControl is set to false in map-client and zoomControlPosition is passed in some truthy value. You could perhaps change the condition to this.zoomControl && this.zoomControlPosition on line156 to be on the safe side
There was a problem hiding this comment.
Thanks Pratik. I've made the update.
|
@pratikmdhr, should I check in the built dist/main.js file? Or will that get built during release? |
Thanks! @stellarjaysoftware .. i believe |
|
@pratikmdhr you are right, actually, we will delete i #84 |
@dadiorchen i removed the main.js here #95 |
|
@stellarjaysoftware sorry for the delay, was busy in another part of the org, can you please solve the conflicts then I will merge this PR, thanks! |
3 participants
This is a dependency of Greenstand/treetracker-web-map-client#472