Open
Conversation
Collaborator
|
@iib0011 sorry for the delay, thanks for your work on this, I think we need do some change on this, we shouldn't view the filter as directly the URL query parameter, though we are doing so in the web map client (by directly pass on the query parameters), filter means the setting for the map data, we can not use it as option for the map app. so here, we can use query parameter for the web map client, but we should translate to options for the map core, so: |
Author
|
@dadiorchen I don't really know what I should do. Maybe you can update the code in the branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Greenstand/treetracker-web-map-client#505
https://dev.treetracker.org/?userid=5556&presentation=simple will not animate anymore