Computer Monitor Cover Features#3531
Computer Monitor Cover Features#3531Ghostipedia merged 136 commits intoGregTechCEu:1.20.1from TarLaboratories:dynamic-covers
Conversation
…dded color support
…iousText placeholder)
|
This is pretty cool, I'll have to give it a check over ingame while others review it 👍 |
Ghostipedia
added
the
type: feature
screret
left a comment
screret
left a comment
There was a problem hiding this comment.
Doing it this way is bound to make peoples' worlds much laggier (in terms of FPS), as BERs aren't very efficient.
Instead of making all machines and pipes have a BER and having the cover render information on itself, the Central monitor should be ported in full (check 1.12 for that).
src/main/java/com/gregtechceu/gtceu/api/registry/registrate/GTRegistrate.java
Outdated
Show resolved
Hide resolved
| modExtraLocalRuntime(forge.curios) | ||
| // modExtraLocalRuntime(forge.worldstripper) | ||
| modExtraLocalRuntime(forge.cc.tweaked.forge.impl) | ||
| // modExtraLocalRuntime(forge.cc.tweaked.forge.impl) for some reason this breaks create |
There was a problem hiding this comment.
this should be looked into
There was a problem hiding this comment.
it appears to be an issue between cc tweaked and create, it crashes even without gtceu
There was a problem hiding this comment.
Currently reaching out to someone I know does a bunch of CC:Tweaked and Create compat. They may know why- I believe for the time being we should mark this review comment as something worth investigating in a different PR.
Due to the nature and size of this PR, it'd be a good idea to get this into the 7.1.0-SNAPSHOT cycle now so it has ample time to get testers to find bugs and edge cases that we'll need to handle.
src/main/resources/assets/gtceu/textures/block/cover/computer_monitor_emissive.png
Outdated
Show resolved
Hide resolved
|
also, you should run the |
|
Can we get some info on how to use the Central Monitor added here? I can't seem to figure out the wireless transmission part (if it's complete?) |
|
It is complete, though quite unintuitive. |
|
Gameplay docs are already written but the PR isn't merged yet |
|
Thanks so much for the quick reply! I seem to be stuck on the "Set hatch as target" part. I assume I'm meant to click the Set Target button after selecting a group but nothing seems to happen |
|
To select the hatch, right-click it, it should then be highlighted with blue. A number input should appear when you do that. It's for the number of the slot the data stick is in. Then click "set target" (there will be no visual feedback though) |
|
I really should've made this more intuitive |
Best time was when you made the PR, second best time is today ;) |
|
Okay... So the full process is:
Phew! This has been driving me crazy! Thanks for the help! But yeah, could be a wee bit more intuitive :) Either way, really excited to have this available. I've been wanting to remote monitor my machines and this scratches that itch nicely. GUI Proxy when tho? :D |
|
GUI Proxy is probably 8.0 or 8.1, after UI rework, and when i figure out how to do that :) |
|
PR with the docs is this one btw: #3900 |
7 participants
What
Made the computer monitor cover display configurable text instead of just decorative green lines.
The text has placeholder support.
There are a lot of placeholders available, such as itemCount, energy, fluidCount, etc.. They can even interact with vanilla redstone and create display and redstone links.
Implementation Details
In order to make covers render text, I had to make all coverables have BERs
Outcome
Made the computer monitor cover display configurable text with placeholders.
Additional Information
Screenshots:
Potential Compatibility Issues
The game doesn't launch with GTCEu, Create and CC:Tweaked, though it seems to be an issue between Create and CC:Tweaked, because if launching without GTCEu it still crashes.