Merged
Conversation
YoungOnionMC
added
type: feature
screret
suggested changes
Jul 27, 2025
screret
suggested changes
Jul 27, 2025
screret
previously requested changes
Jul 27, 2025
… into yo/fluids # Conflicts: # src/main/java/com/gregtechceu/gtceu/common/data/materials/UnknownCompositionMaterials.java
Ghostipedia
approved these changes
Sep 14, 2025
LeoDreamer2004
pushed a commit
to LeoDreamer2004/GregTech-Modern
that referenced
this pull request
Dec 20, 2025
Co-authored-by: Caedis <Caedis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes up the GT bucket behavior to allow placing fluids in world if they have a fluid block
fixes #633
Implementation Details
restructures how bucket interaction works :p
Outcome
fluids can be placed
Additional Information
this should only add the API to allow fluid blocks, it does not add any actual fluid blocks at the moment
also does not deal with fluid world interactions nor and custom stuff like damaging