Add more things that can be copy/pasted using Machine Memory Card#3628
Closed
TarLaboratories wants to merge 41 commits intoGregTechCEu:1.20.1from
TarLaboratories:improved-machine-copying
Closed
Add more things that can be copy/pasted using Machine Memory Card#3628TarLaboratories wants to merge 41 commits intoGregTechCEu:1.20.1from TarLaboratories:improved-machine-copying
TarLaboratories wants to merge 41 commits intoGregTechCEu:1.20.1from
TarLaboratories:improved-machine-copying
Conversation
…mproved-machine-copying
screret
previously requested changes
Aug 21, 2025
src/main/java/com/gregtechceu/gtceu/api/machine/feature/ICopyable.java
Outdated
Show resolved
Hide resolved
...ain/java/com/gregtechceu/gtceu/common/item/tool/behavior/MetaMachineConfigCopyBehaviour.java
Outdated
Show resolved
Hide resolved
...ain/java/com/gregtechceu/gtceu/common/item/tool/behavior/MetaMachineConfigCopyBehaviour.java
Outdated
Show resolved
Hide resolved
Ghostipedia
added
type: feature
jurrejelle
requested changes
Aug 28, 2025
Contributor
jurrejelle
left a comment
jurrejelle
left a comment
There was a problem hiding this comment.
Initial review while cooking, will do more thorough after these changes
...ain/java/com/gregtechceu/gtceu/common/item/tool/behavior/MetaMachineConfigCopyBehaviour.java
Outdated
Show resolved
Hide resolved
...ain/java/com/gregtechceu/gtceu/common/item/tool/behavior/MetaMachineConfigCopyBehaviour.java
Outdated
Show resolved
Hide resolved
...ain/java/com/gregtechceu/gtceu/common/item/tool/behavior/MetaMachineConfigCopyBehaviour.java
Outdated
Show resolved
Hide resolved
jurrejelle
approved these changes
Aug 29, 2025
Contributor
jurrejelle
left a comment
jurrejelle
left a comment
There was a problem hiding this comment.
lgtm, will probably want plenty of feedback from testers (and maybe write tests ourselves) because I feel features like this are most susceptible to (dupe) bugs, but I can't spot anything wrong with it
jurrejelle
previously approved these changes
Aug 29, 2025
…M NEVER WORKING WITH THEM AGAIN)
… DOESNT WORK, ...)
…fixes (IF IT STILL DOESNT WORK, ...)
jurrejelle
dismissed
their stale review
Found out about inconsistencies in paste logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds copying covers and parallel hatch config.
When copying a multiblock controller it will also copy the entire multiblock with all the hatches and busses.
Outcome
Machine memory card now copies covers, parallel hatches and multiblocks.
Fixes #3756