Wrench improvements#3690
Wrench improvements#3690TarLaboratories merged 9 commits intoGregTechCEu:1.20.1from TarLaboratories:fix-wrench-mode-switching
Conversation
…reate's block pickup behaviour for tagged blocks
src/main/java/com/gregtechceu/gtceu/common/item/tool/behavior/ToolModeSwitchBehavior.java
Outdated
Show resolved
Hide resolved
|
Does this have to be a packet? I think there is a Forge event that gets called when a block is right-clicked, before the regular right-click action is attempted, |
screret
left a comment
There was a problem hiding this comment.
Uaing any Create classes will make the game crash if create isn't installed.
src/main/java/com/gregtechceu/gtceu/common/item/tool/behavior/ToolModeSwitchBehavior.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/item/tool/behavior/ToolModeSwitchBehavior.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/network/packets/CPacketToolRightClick.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/item/tool/behavior/ToolModeSwitchBehavior.java
Outdated
Show resolved
Hide resolved
|
It does not crash without Create because of the |
|
it can still crash because java's class verifier can (attempt to) load Create classes even if they aren't actually used at any point. |
src/main/java/com/gregtechceu/gtceu/common/item/tool/behavior/ToolModeSwitchBehavior.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/item/tool/behavior/ToolModeSwitchBehavior.java
Outdated
Show resolved
Hide resolved
That is incorrect. |
src/main/java/com/gregtechceu/gtceu/common/item/tool/behavior/ToolModeSwitchBehavior.java
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/item/tool/behavior/ToolModeSwitchBehavior.java
Show resolved
Hide resolved
jurrejelle
left a comment
There was a problem hiding this comment.
Tar said he tested it, in which case LGTM :D
Co-authored-by: Ghostipedia / Caitlynn <46772882+Ghostipedia@users.noreply.github.com>
What
Adds the ability to pick up Create's blocks (and certain vanilla blocks) with a GT wrench similar to how Create's wrench works.
Also makes the GT wrench not cycle modes when right-clicking on a block.
Outcome
Resolves #3677