Skip to content

Even more cover tests#3854

Merged
jurrejelle merged 26 commits into1.20.1from
tar/more-cover-tests
Sep 11, 2025
Merged

Even more cover tests#3854
jurrejelle merged 26 commits into1.20.1from
tar/more-cover-tests

Conversation

@TarLaboratories
Copy link
Copy Markdown
Contributor

@TarLaboratories TarLaboratories commented Sep 3, 2025 •
edited
Loading

What

Even more cover tests
Currently includes tests for:

  • Pump cover
  • Filter cover
  • Shutter cover
  • Advanced detector covers
  • Wireless transmitter cover (and, by extension, the central monitor)
  • The pipenet

Implementation details

Moved all cover tests from the api.cover package to the common.cover package to allow accessing protected and private members of the corresponding classes in tests (for example PumpCoverTest can access all private members of PumpCover)

Outcome

More tests yay!

@TarLaboratories TarLaboratories added 1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. type: tests Test related changes labels Sep 3, 2025
@github-actions github-actions bot added the Tests: Passed Game Tests have passed on this PR label Sep 3, 2025
@github-actions github-actions bot added Tests: Failed Game Tests have failed on this PR and removed Tests: Passed Game Tests have passed on this PR labels Sep 4, 2025
@github-actions github-actions bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Sep 5, 2025
@github-actions github-actions bot added Tests: Failed Game Tests have failed on this PR and removed Tests: Passed Game Tests have passed on this PR labels Sep 5, 2025
@github-actions github-actions bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Sep 5, 2025
@github-actions github-actions bot added Tests: Failed Game Tests have failed on this PR and removed Tests: Passed Game Tests have passed on this PR labels Sep 5, 2025
@github-actions github-actions bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Sep 5, 2025
@github-actions github-actions bot added Tests: Failed Game Tests have failed on this PR and removed Tests: Passed Game Tests have passed on this PR labels Sep 5, 2025
@github-actions github-actions bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Sep 10, 2025
@github-actions github-actions bot added Tests: Failed Game Tests have failed on this PR and removed Tests: Passed Game Tests have passed on this PR labels Sep 10, 2025
@github-actions github-actions bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Sep 10, 2025
@jurrejelle jurrejelle enabled auto-merge (squash) September 11, 2025 14:41
@jurrejelle jurrejelle merged commit 12e7968 into 1.20.1 Sep 11, 2025
3 of 4 checks passed
@jurrejelle jurrejelle deleted the tar/more-cover-tests branch September 11, 2025 14:43
@github-actions github-actions bot added Tests: Failed Game Tests have failed on this PR and removed Tests: Passed Game Tests have passed on this PR labels Sep 11, 2025
@DilithiumThoride DilithiumThoride added the ignore changelog PR should not be added to the changelog. label Sep 16, 2025
LeoDreamer2004 pushed a commit to LeoDreamer2004/GregTech-Modern that referenced this pull request Dec 20, 2025
@TarLaboratories @LeoDreamer2004
Even more cover tests (GregTechCEu#3854)
0514806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jurrejelle jurrejelle jurrejelle approved these changes

Assignees

No one assigned

Labels

1.20.1 ignore changelog PR should not be added to the changelog. Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. Tests: Failed Game Tests have failed on this PR type: tests Test related changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TarLaboratories @jurrejelle @DilithiumThoride