Fix Conveyor cover Round Robin with Restriction mode#3855
Merged
DilithiumThoride merged 12 commits into1.20.1from Sep 12, 2025
Merged
Fix Conveyor cover Round Robin with Restriction mode#3855DilithiumThoride merged 12 commits into1.20.1from
DilithiumThoride merged 12 commits into1.20.1from
Conversation
DilithiumThoride
added
1.20.1
Release: Patch - 0.0.X
jurrejelle
requested changes
Sep 4, 2025
Contributor
jurrejelle
left a comment
jurrejelle
left a comment
There was a problem hiding this comment.
Clarification question and variable rename suggestion
src/main/java/com/gregtechceu/gtceu/common/pipelike/item/ItemNetHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/pipelike/item/ItemNetHandler.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jurre Groenendijk <jurre@jilles.com>
jurrejelle
approved these changes
Sep 4, 2025
…s. I am not happy with this implementation though.
DilithiumThoride
added a commit
that referenced
this pull request
Sep 4, 2025
YoungOnionMC
previously requested changes
Sep 4, 2025
src/main/java/com/gregtechceu/gtceu/common/pipelike/item/ITEMNETSET.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/pipelike/item/ITEMNETSET.java
Outdated
Show resolved
Hide resolved
DilithiumThoride
changed the title
jurrejelle
dismissed
YoungOnionMC’s stale review
Changes were addressed (comments added and name changed)
jurrejelle
approved these changes
Sep 12, 2025
LeoDreamer2004
pushed a commit
to LeoDreamer2004/GregTech-Modern
that referenced
this pull request
Dec 20, 2025
Co-authored-by: Jurre Groenendijk <jurre@jilles.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The current implementation of a Conveyor Cover set to Round Robin With Priority does not transfer items. The transfer logic gets stuck in an infinite recursion. Also the variable names were unreadable.
This rewrites the logic in full, altering and renaming the behavior. The new behavior, Round Robin with Restriction, performs the same as Round Robin, but attempts to ignore destinations that have at least one Restrictive Item Pipe on their path.
EDIT: Also apparently the existing RRPrio has a massive item dupe bug in it, so it does really need to be rewritten.