Merged
Conversation
DilithiumThoride
added
1.20.1
Release: Patch - 0.0.X
# Conflicts: # src/test/java/com/gregtechceu/gtceu/gametest/util/TestUtils.java
…ranged-inputs-tests # Conflicts: # src/test/java/com/gregtechceu/gtceu/gametest/util/TestUtils.java
github-actions
bot
added
Tests: Failed
github-actions
bot
added
Tests: Passed
jurrejelle
previously requested changes
Sep 25, 2025
src/test/java/com/gregtechceu/gtceu/api/recipe/ingredient/IntProviderFluidIngredientTest.java
Outdated
Show resolved
Hide resolved
Contributor
|
Do Not Merge - As discussed indiscord, we want to add tests for GTLookup using ranged map ingredients :) |
Contributor
Author
(There actually isn't a distinct "ranged map ingredient", it's just a normal map ingredient that takes the max roll during the search and simulation) |
DilithiumThoride
added
ignore changelog
jurrejelle
requested changes
Oct 1, 2025
Contributor
jurrejelle
left a comment
jurrejelle
left a comment
There was a problem hiding this comment.
A few tiny changes, and maybe you can make (very simple) IntProvider[Fluid]Ingredient tests like IntProviderIngredient.of(..., intProvider).test(...) or creating an ItemStackMapIngredient with an int provider and checking .equals? lmk if you need me to elaborate or if that doesn't work :)
src/test/java/com/gregtechceu/gtceu/api/recipe/ingredient/IntProviderFluidIngredientTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/gregtechceu/gtceu/api/recipe/ingredient/IntProviderFluidIngredientTest.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
…nd test serialization
…nt, and test serialization
jurrejelle
approved these changes
Oct 3, 2025
LeoDreamer2004
pushed a commit
to LeoDreamer2004/GregTech-Modern
that referenced
this pull request
Dec 20, 2025
Co-authored-by: Jurre Groenendijk <jurre@jilles.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds test cases for Ranged Item and Fluid Ingredients