fix offsets bugging out when there are multiple faces passed to a FluidAreaRender#3858
Merged
jurrejelle merged 1 commit intoGregTechCEu:1.20.1from Sep 4, 2025
Merged
Conversation
YoungOnionMC
approved these changes
Sep 4, 2025
YoungOnionMC
added
type: bugfix
LeoDreamer2004
pushed a commit
to LeoDreamer2004/GregTech-Modern
that referenced
this pull request
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FluidAreaRenders bug out and apply their offsets repeatedly to themselves if there are multiple RelativeDirections passed in as faces.
Implementation Details
Moves poseStack push and pop into the for loop instead of outside it.
Outcome
FluidAreaRenders render correctly if given a drawFaces list longer than 1.
Additional Information
Before fix:
After fix:
