Add conveyorRoundRobinTest to the coverTests#3860
Draft
jtuc wants to merge 1 commit intoGregTechCEu:1.20.1from
Draft
Add conveyorRoundRobinTest to the coverTests#3860jtuc wants to merge 1 commit intoGregTechCEu:1.20.1from
jtuc wants to merge 1 commit intoGregTechCEu:1.20.1from
Conversation
jurrejelle
added
ignore changelog
Contributor
Author
|
Test is failing after I rebased to latest - looks like maybe I need to call something extra to get the pipe connections synced properly? Drafting for now, will have another go later. |
Contributor
Author
|
Possibly failing due to #3862? Test consistently fails for me in-client, but consistently passes from |
jtuc
force-pushed
the
conveyor-round-robin-test
branch
from
62054b4 to
75d961d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a new conveyorRoundRobinTest to the conveyor gametests.
Implementation Details
I'm using the empty5x5 template and placing blocks via code - it's possible that setting up the test via a structure would be better? I've done it via code for now to match the other tests and make similar tests easier to write.
This is the first time I've messed with gametests, so any feedback would be appreciated.
Additional Information
I think this is the first gametest that exercises the PipeNet code?
It would probably be a good idea to also have a test for
DistributionMode.ROUND_ROBIN_PRIO, but it seems there's still some discussion on what that mode is actually supposed to do.