Skip to content

Fix lombok for recipe after finish#3885

Merged
DilithiumThoride merged 1 commit intodt/jade-workingfrom
jj/fix-lombok-recipe-after-finish
Sep 10, 2025
Merged

Fix lombok for recipe after finish#3885
DilithiumThoride merged 1 commit intodt/jade-workingfrom
jj/fix-lombok-recipe-after-finish

Conversation

@jurrejelle
Copy link
Copy Markdown
Contributor

What

The reason you had to change it is because lombok is "smart" and sees "suspend" as an adjective, so it becomes "isSuspendAfterFinish" instead. Didn't want to just push to your branch without asking so I made a branch for it, feel free to review before merging to make the code cleaner

@jurrejelle jurrejelle requested a review from a team as a code owner September 9, 2025 10:30
@jurrejelle jurrejelle added ignore changelog PR should not be added to the changelog. 1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. labels Sep 9, 2025
@github-actions github-actions bot added the Tests: Passed Game Tests have passed on this PR label Sep 9, 2025
@krossgg
Copy link
Copy Markdown
Contributor

krossgg commented Sep 9, 2025

It's not because it's an adjective, it's because suspendAfterFinish is a boolean. See https://projectlombok.org/features/GetterSetter
Can be disabled with a param in the @Getter I think.

@DilithiumThoride DilithiumThoride merged commit e308397 into dt/jade-working Sep 10, 2025
6 of 7 checks passed
@DilithiumThoride DilithiumThoride deleted the jj/fix-lombok-recipe-after-finish branch September 10, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 ignore changelog PR should not be added to the changelog. Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. Tests: Passed Game Tests have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants