Allow ULV Input Hatches in Primitive Pump Multiblock#3892
Merged
Ghostipedia merged 7 commits intoGregTechCEu:1.20.1from Sep 14, 2025
Merged
Allow ULV Input Hatches in Primitive Pump Multiblock#3892Ghostipedia merged 7 commits intoGregTechCEu:1.20.1from
Ghostipedia merged 7 commits intoGregTechCEu:1.20.1from
Conversation
TarLaboratories
approved these changes
Sep 12, 2025
TarLaboratories
added
type: feature
YoungOnionMC
previously requested changes
Sep 12, 2025
src/main/java/com/gregtechceu/gtceu/common/data/machines/GTMultiMachines.java
Outdated
Show resolved
Hide resolved
Contributor
|
Since it's a breaking change for the multi, could you add a quick 1-2 line note at docs/content/Modpacks/Changes/v7.2.0.md about it? |
jurrejelle
approved these changes
Sep 12, 2025
Ghostipedia
approved these changes
Sep 14, 2025
Ghostipedia
approved these changes
Sep 14, 2025
LeoDreamer2004
pushed a commit
to LeoDreamer2004/GregTech-Modern
that referenced
this pull request
Dec 20, 2025
Co-authored-by: Jurre Groenendijk <jurre@jilles.com> Co-authored-by: Ghostipedia / Caitlynn <46772882+Ghostipedia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow using ULV Input Hatches in the Primitive Pump Multiblock (currently only LV and MV are allowed).
I assume this was a mistake and was supposed to be ULV and LV due to
PrimitivePumpMachine#initializeTankspecifically having a check for a Tank with 8 buckets which would be the ULV one but as it stands LV and MV both get the 4x hatchModifier(assuming the allowed hatches are wrong not the bucket check)
If it was meant the other way around (or not at all) simply close this and implement it, i only thought for this simple change i don't need to ask anyone and just do it
Implementation Details
Outcome
You can now have a Primitive Pump that can utilize the 2x hatcMultiplier instead of only 1x / 4x
Potential Compatibility Issues
I have elected to not remove the MV hatch from the allowed blocks as this would break existing multis. I dont know what your stance here is on multi's breaking changes