Skip to content

Rework RecipeLogicTest + add 2 slot test#3898

Merged
jurrejelle merged 2 commits into1.20.1from
jj/test/recipe-removal
Sep 14, 2025
Merged

Rework RecipeLogicTest + add 2 slot test#3898
jurrejelle merged 2 commits into1.20.1from
jj/test/recipe-removal

Conversation

@jurrejelle
Copy link
Copy Markdown
Contributor

What

Rework recipe logic tests to use our new concepts (busHolder, TestUtils methods)
Add test for items in 2 slots
Rename failing tests to indicate why they fail
Add more attempts for flakey test

Implementation Details

In the new system, the singleblock test is blocked by LDLib sync issues (#3896).

Outcome

The test should be more stable, and we have another test case now

@jurrejelle jurrejelle requested a review from a team as a code owner September 14, 2025 08:43
@jurrejelle jurrejelle added ignore changelog PR should not be added to the changelog. 1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. type: tests Test related changes labels Sep 14, 2025
@github-actions github-actions bot added the Tests: Passed Game Tests have passed on this PR label Sep 14, 2025
@jurrejelle jurrejelle merged commit 28589a7 into 1.20.1 Sep 14, 2025
4 checks passed
@jurrejelle jurrejelle deleted the jj/test/recipe-removal branch September 14, 2025 09:22
LeoDreamer2004 pushed a commit to LeoDreamer2004/GregTech-Modern that referenced this pull request Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 ignore changelog PR should not be added to the changelog. Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. Tests: Passed Game Tests have passed on this PR type: tests Test related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants