[MUI2] Port Ender Link Covers#4140
Closed
purebluez wants to merge 22 commits intoGregTechCEu:mui2-refactorfrom
Closed
[MUI2] Port Ender Link Covers#4140purebluez wants to merge 22 commits intoGregTechCEu:mui2-refactorfrom
purebluez wants to merge 22 commits intoGregTechCEu:mui2-refactorfrom
Conversation
# Conflicts: # src/main/java/com/gregtechceu/gtceu/api/cover/IMuiCover.java # src/main/java/com/gregtechceu/gtceu/common/cover/MachineControllerCover.java # src/main/java/com/gregtechceu/gtceu/common/cover/ender/AbstractEnderLinkCover.java # src/main/java/com/gregtechceu/gtceu/common/cover/ender/EnderFluidLinkCover.java # src/main/java/com/gregtechceu/gtceu/common/cover/ender/EnderItemLinkCover.java # src/main/java/com/gregtechceu/gtceu/common/cover/ender/EnderRedstoneLinkCover.java # src/main/java/com/gregtechceu/gtceu/common/mui/GTGuiTextures.java
Contributor
|
NOTE: wait until ported to latest, then try again. Make sure to e..g for items do |
Draft
Member
|
Implemented in a different PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ports the ender fluid, item, and redstone link covers to MUI2. they all use the same base ui so its a combined pr for all 3
Implementation Details
the channel list is completely cooked. you can make it work again by taking the description text field out of its own Row and making it just a lone widget, but then it crashes the game when you use it because its syncmanager is null. im like 90% sure this bug isnt my fault and i have zero idea what could possibly be causing it so once i submit this pr i will make a post in the mui2 bug compendium issue (4032)
Outcome
a completely new ui for my beloved ender link covers and it has better ux since the textfield can have individual sections copied, deleted, replaced, etc. also you dont need to hit a checkmark and you can now just hit enter or click off the field and it saves it 🧇
Additional Information
the OLD guis
the NEW guis
the new ones have a different color because they respect the alpha/transparency value (the last byte) of the color code and behind it is black. i can change this if wanted but i think it makes more sense than having a visually useless byte at the end.
also the rightmost widget in the settings row (bottom) is a button with that exclamation because its just temp. its waiting on filter slots to get finished so im gonna mark this pr as draft until then. its a similar deal with the power button (leftmost on settings/bottom row) because the power button texture that it uses is currently declared in another branch and i dont wanna cause merge conflicts or duplicate code