Rework machine copy/paste card to support copying pipes, covers, cover settings, and more machine settings#4272
Merged
gustovafing merged 14 commits into1.20.1from Jan 14, 2026
Merged
Conversation
gustovafing
added
type: feature
YoungOnionMC
approved these changes
Dec 6, 2025
jurrejelle
requested changes
Dec 13, 2025
Contributor
jurrejelle
left a comment
jurrejelle
left a comment
There was a problem hiding this comment.
I love these changes, I do have a few notes:
- Since I think this is a change that requires all covers etc to override this, could you make docs for it?
- I think this is peak testable PR, could you / do you want to make a bunch of tests e.g. placing down stuff with certain rotations/configurations/colors/edits/whatever and manually calling copy / paste on it to make sure the right things are copied/pasted and actually come through? if not I could have a look at making them into this PR
jurrejelle
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reworks the machine memory card to use a new system based on the interface
ICopyable, which is implemented by machines and covers to allow for more values to be copied. The new copy behaviour allows for many more machine settings to be copied, including covers and cover settings. Additionally, the card can now copy/paste the connections, shutters, and covers of pipe segments.