Make KubeJS registration assume gtceu namespace unless otherwise specified#4428
Closed
screret wants to merge 4 commits intoGregTechCEu:1.21from
Closed
Make KubeJS registration assume gtceu namespace unless otherwise specified#4428screret wants to merge 4 commits intoGregTechCEu:1.21from
gtceu namespace unless otherwise specified#4428screret wants to merge 4 commits intoGregTechCEu:1.21from
Conversation
…l state, by clearing it if the parsing didn't go through the string path
| "client.BiomeColorsMixin", | ||
| "client.BlockModelMixin", | ||
| "client.ClientLevelAccessor", | ||
| "client.FaceBakeryMixin", |
Contributor
There was a problem hiding this comment.
This shouldn't be re-ordered, that would need to be a separate PR
Contributor
Author
There was a problem hiding this comment.
Intellij just did that I didn't touch it
Contributor
|
Closing due to duplicate effort; we can always reopen and merge if the current implementation is found flawed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make registering GT-related things (materials, elements, machines, GT recipe types..) with KubeJS use the
gtceunamespace (instead ofkubejs), unless otherwise specified.Implementation Details
A single mixin to detect KubeJS applying the implicit namespace and some methods to mutate the builder's resource location based on that information.
Outcome
Adding GT things with KubeJS uses the
gtceunamespace by default, like in 1.20.Additional Information
if yall can think of less wordy names for the methods go for it, you can push to the PR branch