Skip to content

Make solar tests optional#4447

Closed
jurrejelle wants to merge 3 commits into1.20.1-v8.0.0from
jj/fix-solar-tests-correct-branch
Closed

Make solar tests optional#4447
jurrejelle wants to merge 3 commits into1.20.1-v8.0.0from
jj/fix-solar-tests-correct-branch

Conversation

@jurrejelle
Copy link
Copy Markdown
Contributor

@jurrejelle jurrejelle commented Jan 8, 2026

We can't get them to work consistently. If someone else wants to try, feel free, but it's a ton of headache over testing something of not too much value

@jurrejelle jurrejelle requested a review from a team as a code owner January 8, 2026 19:08
@jurrejelle jurrejelle added ignore changelog PR should not be added to the changelog. type: bugfix General bug fixes 1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. labels Jan 8, 2026
@github-actions github-actions bot added the Tests: Failed Game Tests have failed on this PR label Jan 8, 2026
@jurrejelle jurrejelle changed the title Fix solar tests Make solar tests optional Jan 8, 2026
@github-actions github-actions bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Jan 8, 2026
@jurrejelle
Copy link
Copy Markdown
Contributor Author

closed in favor of #4450

@jurrejelle jurrejelle closed this Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 ignore changelog PR should not be added to the changelog. Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. Tests: Passed Game Tests have passed on this PR type: bugfix General bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants