Skip to content

Stop placeholder execution when an exception is encountered #4455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TarLaboratories merged 1 commit into from
Jan 10, 2026
Merged

Stop placeholder execution when an exception is encountered #4455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 31 additions & 31 deletions src/main/java/com/gregtechceu/gtceu/api/placeholder/PlaceholderHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,31 +84,31 @@ public static MultiLineComponent processPlaceholders(String s, PlaceholderContex
int symbol = 1;
Stack<List<MultiLineComponent>> stack = new Stack<>();
stack.push(GTUtil.list(MultiLineComponent.empty()));
for (char c : s.toCharArray()) {
if (escape || (literalEscape && c != LITERAL_ESCAPE)) {
if (c == ESCAPED_NEWLINE && !literalEscape) {
GTUtil.getLast(stack.peek()).appendNewline();
line++;
symbol = 0;
} else if (c == NEWLINE) continue;
else GTUtil.getLast(stack.peek()).append(c);
} else {
switch (c) {
case ESCAPE -> escapeNext = true;
case LITERAL_ESCAPE -> literalEscape = !literalEscape;
case NEWLINE -> {
try {
for (char c : s.toCharArray()) {
if (escape || (literalEscape && c != LITERAL_ESCAPE)) {
if (c == ESCAPED_NEWLINE && !literalEscape) {
GTUtil.getLast(stack.peek()).appendNewline();
line++;
symbol = 0;
}
case ARG_SEPARATOR -> {
if (stack.size() == 1) GTUtil.getLast(stack.peek()).append(c);
else stack.peek().add(MultiLineComponent.empty());
}
case PLACEHOLDER_BEGIN -> stack.push(GTUtil.list(MultiLineComponent.empty()));
case PLACEHOLDER_END -> {
List<MultiLineComponent> placeholder = stack.pop();
try {
} else if (c == NEWLINE) continue;
else GTUtil.getLast(stack.peek()).append(c);
} else {
switch (c) {
case ESCAPE -> escapeNext = true;
case LITERAL_ESCAPE -> literalEscape = !literalEscape;
case NEWLINE -> {
GTUtil.getLast(stack.peek()).appendNewline();
line++;
symbol = 0;
}
case ARG_SEPARATOR -> {
if (stack.size() == 1) GTUtil.getLast(stack.peek()).append(c);
else stack.peek().add(MultiLineComponent.empty());
}
case PLACEHOLDER_BEGIN -> stack.push(GTUtil.list(MultiLineComponent.empty()));
case PLACEHOLDER_END -> {
List<MultiLineComponent> placeholder = stack.pop();
if (stack.isEmpty()) throw new UnexpectedBracketException();
MultiLineComponent result = processPlaceholder(placeholder, ctx);
if (result.isIgnoreSpaces() || stack.size() == 1) {
Expand All @@ -134,19 +134,19 @@ public static MultiLineComponent processPlaceholders(String s, PlaceholderContex
if (i != result.size() - 1) GTUtil.getLast(stack.peek()).appendNewline();
}
}
} catch (PlaceholderException e) {
e.setLineInfo(line, symbol);
exceptions.add(e);
} catch (RuntimeException e) {
exceptions.add(e);
}
default -> GTUtil.getLast(stack.peek()).append(c);
}
default -> GTUtil.getLast(stack.peek()).append(c);
}
escape = escapeNext;
escapeNext = false;
symbol++;
}
escape = escapeNext;
escapeNext = false;
symbol++;
} catch (PlaceholderException e) {
e.setLineInfo(line, symbol);
exceptions.add(e);
} catch (RuntimeException e) {
exceptions.add(e);
}
if (stack.size() > 1) {
PlaceholderException exception = new UnclosedBracketException();
Expand Down