Conversation
|
Though this is an improvement, I would be weary of the |
|
It is true for a LAN host, but if you've got someone on your LAN who wants to hack you I'm pretty sure you've got bigger problems than this :) |
|
Well the thing with LAN is you have no control over who can join without additional mods. As well, LAN is used with mods like e4mc to open it up to the internet. The impact is severe enough, it at least would need a significant user warning to have that feature enabled. A LAN network may not be something you have control over in shared living spaces, though less likely to be a target I would not imagine a user to be comfortable knowing of that possibility. For still running on server side, that can be alright if fully safe guarded with an option to disable. As well as some additional notices about importance of those allowed domains to prevent any local network web servers being inadvertently accessible. |
| if (!allowedProtocol) return NULL_MARKER; | ||
| boolean allowedDomain = singleplayer; | ||
| for (String domain : ConfigHolder.INSTANCE.gameplay.allowedDomains) { | ||
| if (url.getHost().equalsIgnoreCase(domain)) { |
There was a problem hiding this comment.
Can this use regular equals()?
What
Only allow http and https in central monitor