Start of new machine trait system#4479
Merged
gustovafing merged 29 commits into1.20.1-v8.0.0from Jan 26, 2026
Merged
Conversation
TechLord22
reviewed
Jan 17, 2026
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTraitType.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTraitType.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTraitType.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTraitType.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/feature/IInteractionTrait.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/MetaMachine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/MetaMachine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTraitType.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTraitType.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTraitType.java
Outdated
Show resolved
Hide resolved
TechLord22
reviewed
Jan 17, 2026
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTraitType.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTraitType.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
Tests: Passed
jurrejelle
requested changes
Jan 19, 2026
Contributor
jurrejelle
left a comment
jurrejelle
left a comment
There was a problem hiding this comment.
thoughts on adding a getAllTraits() on the top level MetaMachine that's just a shortcut for getTraitHolder().getAllTraits()? I could see arguments for or against so just curious, since we'll use that method a lot.
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTraitHolder.java
Show resolved
Hide resolved
TechLord22
reviewed
Jan 22, 2026
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTrait.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTrait.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTraitHolder.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTraitHolder.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/MachineTraitType.java
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/machine/trait/NotifiableLaserContainer.java
Show resolved
Hide resolved
Co-authored-by: TechLord22 <37029404+TechLord22@users.noreply.github.com>
…hCEu/GregTech-Modern into gus/machine-refactor-pt2
TechLord22
approved these changes
Jan 22, 2026
jurrejelle
requested changes
Jan 23, 2026
src/main/java/com/gregtechceu/gtceu/api/block/MetaMachineBlock.java
Outdated
Show resolved
Hide resolved
jurrejelle
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Initial impl of the new machine trait system.