Remove BlockEntity Check in MinerLogic#4488
Merged
jurrejelle merged 1 commit intoGregTechCEu:1.20.1from Jan 24, 2026
Merged
Conversation
lilpaladin1
changed the title
lilpaladin1
changed the title
jurrejelle
added
type: bugfix
jurrejelle
approved these changes
Jan 24, 2026
Contributor
jurrejelle
left a comment
jurrejelle
left a comment
There was a problem hiding this comment.
If someone tags their blockEntity's block with Tags.Blocks.ORES and they don't want it to be mined, that's their problem I feel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In MinerLogic's
getBlockstoMine()there's a check to see if a block is valid to actually be mined. 2 out of 3 checks are fine, but there's one check to see if there isn't a BlockEntity at that position and that ones doesn't really feel like there's a justification for that one, especially in cases where someone DELIBERATELY tags a block that has a BlockEntity as an Ore... which is me, I'm that someone.Implementation Details
Simply removes the BlockEntity check while keeping the other 2 checks.
Outcome
Now any block that is tagged with Ore and has a BlockEntity should be mineable.
Additional Information
I made this PR because I was doing something that was conflicting with this BlockEntity check because it was the only reasonable way to actually do the thing I wanted to do.
Potential Compatibility Issues
I can probably think of a really stupid edge case with containers but at the same time the other 2 remaining checks should stop that from happening unless that tag was deliberately put in place.