Merged
Conversation
# Conflicts: # src/main/java/com/gregtechceu/gtceu/api/data/chemical/material/Material.java # src/main/java/com/gregtechceu/gtceu/api/data/chemical/material/info/MaterialFlags.java # src/main/java/com/gregtechceu/gtceu/common/data/GTRecipes.java
Co-authored-by: Jurre Groenendijk <jurre@jilles.com>
Co-authored-by: Jurre Groenendijk <jurre@jilles.com>
Co-authored-by: Jurre Groenendijk <jurre@jilles.com>
Co-authored-by: Jurre Groenendijk <jurre@jilles.com>
…turbine and steam multiblocks.
# Conflicts: # docs/content/Modpacks/Other-Topics/Custom-Sounds.md
gustovafing
added
the
Release: Patch - 0.0.X
gustovafing
requested changes
Jan 28, 2026
| } | ||
|
|
||
| public static TraceabilityPredicate lampsByColor(DyeColor color) { | ||
| return LAMPS_BY_COLOR.getOrDefault(color, anyLamp()); |
Member
There was a problem hiding this comment.
Instead of using a static context to pre-load all lamps by colour, use Map.computeIfAbsent()
gustovafing
approved these changes
Jan 28, 2026
jurrejelle
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an any lamps predicate and api for specific colors of lamps. Using the normal block predicate doesn't allow the terminal to place lamps.
Implementation Details
The predicate to use all lamps is: Predicates.anyLamp()
The predicate to use a specific color is : Predicates.lampsByColor(DyeColor.DYE_COLOR)
Outcome
A short description of what this PR added/fixed/changed/removed.
Adds lamp predicates, allowing lamps to be used in multiblocks. Without these, the terminal won't place lamps because of the nbt.
How Was This Tested
This section is for screenshots, code snippets or descriptions of how the PR was tested in code or in game to ensure correctness.
Potential Compatibility Issues
Shouldn't be any.