Fix wireless_transmitter_cover_test not working on systems where the decimal separator isn't a dot#4521
Merged
jurrejelle merged 1 commit intoGregTechCEu:1.20.1from Jan 29, 2026
Conversation
…decimal separator isn't a dot (like german or finnish locale, where it's a comma)
jurrejelle
added
ignore changelog
jurrejelle
approved these changes
Jan 29, 2026
YoungOnionMC
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix wireless_transmitter_cover_test not working on systems where the decimal separator isn't a dot.
Like german or finnish locale, where it's a comma.
Implementation Details
Made it use
String.format(Locale.ROOT, ...instead of"constant".formatted(...).Outcome
Tests succeed on my PC again
How Was This Tested
Ran tests, worked, didn't work before