Use resource keys for world gen layers#4527
Closed
screret wants to merge 17 commits intoGregTechCEu:1.20.1-v8.0.0from
Closed
Use resource keys for world gen layers#4527screret wants to merge 17 commits intoGregTechCEu:1.20.1-v8.0.0from
screret wants to merge 17 commits intoGregTechCEu:1.20.1-v8.0.0from
Conversation
…cations for the dimension filter
and cache it because the code ended up kind of messy otherwise
YoungOnionMC
approved these changes
Feb 4, 2026
YoungOnionMC
added
type: bugfix
…our to a machine trait (GregTechCEu#4500)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make
IWorldGenLayerand its subclasses useResourceKey<Level>instances for dimension matching instead of 'plain'ResourceLocationsImplementation Details
Changed the field/method arg types to
ResourceKey<Level>, removed any.location()calls that were used for converting resource keys to reslocsOutcome
neater code with less unwrapping and less chances for mistakes
Additional Information
IWorldGenLayer#getLevelswas renamed toIWorldGenLayer#getDimensions.Layers created with KubeJS do not require any changes to function.
Potential Compatibility Issues
Addon mods with custom world gen layers have to change their code slighly.
If they have a custom implementation (like GT's where it's an enum), they have to change it a bit more to fix the method names/args.