Fix missing/invalid pipe model issues#4530
Merged
Ghostipedia merged 15 commits intoGregTechCEu:1.20.1from Feb 1, 2026
Merged
Conversation
This reverts commit 97252f0.
…-op won't work as `#exists` is actually used in a couple things
…non-active model doesn't also have those layers
screret
force-pushed
the
sc/fix-missing-model-issues
branch
from
96e025a to
d921f42
Compare
Ghostipedia
approved these changes
Feb 1, 2026
Member
Ghostipedia
left a comment
Ghostipedia
left a comment
There was a problem hiding this comment.
Looks fine at a glance would like @YoungOnionMC to take a look over it as well
Ghostipedia
added
type: bugfix
YoungOnionMC
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix some minor issues that went unnoticed in #4283, like cables having missing textures.
Implementation Details
RuntimeExistingFileHelperwas changed to assume all files exist by default and a version that actually checks whether or not the resource exists was added, accessible withRuntimeExistingFileHelper#activeHelper.Outcome
No more missing texture crash (this was reported in the KubeJS discord a week or so ago)
No more error spam from cables (talked about this in mdt yesterday)
Fixed a bug with 'active' pipes like laser pipes and optical fiber cables probably not using their active textures at all
How Was This Tested
This used to be a missing model cube:
Having something like this (missing texture references in machines) previously crashed the client on load:
Active pipes are now glowy as they should be:
Additional Information
I made getting
PipeModelBuilders into an invalid state harder by making the thickness and model provider arguments required.Potential Compatibility Issues
Nobody used any of this yet, so none