Simplify material block models and fix issues they had with shaders#4532
Merged
Ghostipedia merged 11 commits intoGregTechCEu:1.20.1from Feb 4, 2026
Merged
Conversation
… reference the original model in the blockstate json
it's no longer needed thanks to composite models
Member
|
need clarification on the 'bright red border' we added colored-selector highlighting to material/tier blocks before so if that got reverted that might be an issue and needs to be amended This is infact intended behavior |
YoungOnionMC
previously requested changes
Feb 2, 2026
src/main/java/com/gregtechceu/gtceu/core/mixins/client/LevelRendererMixin.java
Show resolved
Hide resolved
…l blocks, not just `MaterialBlock` instances
…d to be solid anymore
Contributor
Author
|
@Ghostipedia added it back |
Ghostipedia
added
type: bugfix
Ghostipedia
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make most material blocks use 'composite' models for rendering to fix translucency sorting issues.
Cleaned up how the models are actually generated while at it because it required that to be done.
Implementation Details
Most blocks don't create a copy of the parent model anymore & instead reference the parent directly in the block state JSON. Resource pack makers are still able to replace the models by replacing the block state JSON as well.
Outcome
Shaders shouldn't think frames are glass blocks anymore
How Was This Tested
No xray on ore/material blocks:
Additional Information
See "How was this tested" section
Potential Compatibility Issues
Maybe some resource pack? I haven't seen any that change material blocks' models like this, though.