Skip to content

Port hazard and exhaust interfaces to trait system#4584

Merged
gustovafing merged 10 commits into1.20.1from
gus/hazard-traits
Feb 16, 2026
Merged

Port hazard and exhaust interfaces to trait system#4584
gustovafing merged 10 commits into1.20.1from
gus/hazard-traits

Conversation

@gustovafing
Copy link
Member

No description provided.

@gustovafing gustovafing requested a review from a team as a code owner February 8, 2026 22:59
@github-actions github-actions bot added the 1.20.1 label Feb 8, 2026
@github-actions github-actions bot added the Tests: Failed Game Tests have failed on this PR label Feb 8, 2026
@github-actions github-actions bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Feb 11, 2026
YoungOnionMC
YoungOnionMC previously approved these changes Feb 12, 2026
gustovafing and others added 2 commits February 13, 2026 07:51
# Conflicts:
#	src/main/java/com/gregtechceu/gtceu/api/machine/feature/multiblock/IMufflerMachine.java
#	src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/MufflerPartMachine.java
@github-actions github-actions bot added Tests: Failed Game Tests have failed on this PR and removed Tests: Passed Game Tests have passed on this PR labels Feb 12, 2026
Base automatically changed from 1.20.1-v8.0.0 to 1.20.1 February 14, 2026 22:09
@Ghostipedia Ghostipedia dismissed YoungOnionMC’s stale review February 14, 2026 22:09

The base branch was changed.

@github-actions github-actions bot added Tests: Passed Game Tests have passed on this PR and removed Tests: Failed Game Tests have failed on this PR labels Feb 16, 2026
Copy link
Contributor

@jurrejelle jurrejelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so crazy to me seeing these interfaces become a single line in the constructor and it just works, LGTM tho

@gustovafing gustovafing merged commit 28bff24 into 1.20.1 Feb 16, 2026
4 checks passed
@gustovafing gustovafing deleted the gus/hazard-traits branch February 16, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 Tests: Passed Game Tests have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants