Remove IMultiController & IRotorHolderMachine #4590
Merged
gustovafing merged 4 commits into1.20.1-v8.0.0from Feb 12, 2026
Merged
Remove IMultiController & IRotorHolderMachine #4590gustovafing merged 4 commits into1.20.1-v8.0.0from
gustovafing merged 4 commits into1.20.1-v8.0.0from
Conversation
github-actions
bot
added
Tests: Passed
YoungOnionMC
approved these changes
Feb 12, 2026
jurrejelle
reviewed
Feb 12, 2026
Comment on lines
+49
to
+52
| @Override | ||
| default MultiblockControllerMachine self() { | ||
| return (MultiblockControllerMachine) this; | ||
| } |
Contributor
There was a problem hiding this comment.
How is it enforced that any user of IDisplayUIMachine is also a MultiblockControllerMachine?
| public interface IWorkableMultiController extends IMultiController, IRecipeLogicMachine {} | ||
| public interface IWorkableMultiController extends IRecipeLogicMachine { | ||
|
|
||
| MultiblockControllerMachine self(); |
Contributor
There was a problem hiding this comment.
What is this functionality? is it just to convert any IWorkableMultiController to a MultiblockController machine? I'm struggling to understand the inheritance here
jurrejelle
approved these changes
Feb 12, 2026
# Conflicts: # src/main/java/com/gregtechceu/gtceu/api/machine/feature/multiblock/IMultiController.java # src/main/java/com/gregtechceu/gtceu/api/machine/multiblock/MultiblockControllerMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/RotorHolderPartMachine.java # src/main/java/com/gregtechceu/gtceu/common/machine/multiblock/part/monitor/AdvancedMonitorPartMachine.java # src/main/java/com/gregtechceu/gtceu/integration/jade/provider/ParallelProvider.java
github-actions
bot
added
Tests: Failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.