Skip to content

fix KJS builders using volatile instead of transient for hidden fields #4639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustovafing merged 1 commit into from
Feb 15, 2026
Merged

fix KJS builders using volatile instead of transient for hidden fields #4639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...n/java/com/gregtechceu/gtceu/integration/kjs/builders/machine/KJSSteamMachineBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@
public class KJSSteamMachineBuilder extends BuilderBase<MachineDefinition> {

@Setter
public volatile boolean hasLowPressure = true, hasHighPressure = true;
public transient boolean hasLowPressure = true, hasHighPressure = true;
@Setter
public volatile SteamCreationFunction machine = SimpleSteamMachine::new;
public transient SteamCreationFunction machine = SimpleSteamMachine::new;
@Setter
public volatile SteamDefinitionFunction definition = (isHP, def) -> def.tier(isHP ? 1 : 0);
public transient SteamDefinitionFunction definition = (isHP, def) -> def.tier(isHP ? 1 : 0);

private volatile MachineBuilder<?, ?> lowPressureBuilder = null, highPressureBuilder = null;
private volatile MachineDefinition hpValue = null;
private transient MachineBuilder<?, ?> lowPressureBuilder = null, highPressureBuilder = null;
private transient MachineDefinition hpValue = null;

public KJSSteamMachineBuilder(ResourceLocation id) {
super(id);
Expand Down
16 changes: 8 additions & 8 deletions .../java/com/gregtechceu/gtceu/integration/kjs/builders/machine/KJSTieredMachineBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,21 @@ public class KJSTieredMachineBuilder extends BuilderBase<MachineDefinition[]> {
private final MachineBuilder<?, ?>[] builders = new MachineBuilder[TIER_COUNT];

@Setter
public volatile int[] tiers = GTMachineUtils.ELECTRIC_TIERS;
public transient int[] tiers = GTMachineUtils.ELECTRIC_TIERS;
@Setter
public volatile TieredCreationFunction machine;
public transient TieredCreationFunction machine;
@Setter
public volatile DefinitionFunction definition = (tier, def) -> def.tier(tier);
public transient DefinitionFunction definition = (tier, def) -> def.tier(tier);
@Setter
public volatile Int2IntFunction tankScalingFunction = GTMachineUtils.defaultTankSizeFunction;
public transient Int2IntFunction tankScalingFunction = GTMachineUtils.defaultTankSizeFunction;
@Setter
public volatile boolean addDefaultTooltips = true;
public transient boolean addDefaultTooltips = true;
@Setter
public volatile boolean addDefaultModel = true;
public transient boolean addDefaultModel = true;
@Setter
public volatile boolean isGenerator = false;
public transient boolean isGenerator = false;

public volatile BiFunction<ResourceLocation, GTRecipeType, EditableMachineUI> editableUI;
public transient BiFunction<ResourceLocation, GTRecipeType, EditableMachineUI> editableUI;

public KJSTieredMachineBuilder(ResourceLocation id) {
super(id);
Expand Down
6 changes: 3 additions & 3 deletions ...va/com/gregtechceu/gtceu/integration/kjs/builders/machine/KJSTieredMultiblockBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ public class KJSTieredMultiblockBuilder extends BuilderBase<MultiblockMachineDef
private final MultiblockMachineBuilder[] builders = new MultiblockMachineBuilder[TIER_COUNT];

@Setter
public volatile int[] tiers = GTMachineUtils.ELECTRIC_TIERS;
public transient int[] tiers = GTMachineUtils.ELECTRIC_TIERS;
@Setter
public volatile TieredCreationFunction machine;
public transient TieredCreationFunction machine;
@Setter
public volatile DefinitionFunction definition = (tier, def) -> def.tier(tier);
public transient DefinitionFunction definition = (tier, def) -> def.tier(tier);

public KJSTieredMultiblockBuilder(ResourceLocation id) {
super(id);
Expand Down
Loading