Skip to content

Fix IllegalStateException when opening a machine GUI#4661

Merged
jurrejelle merged 1 commit intomui2-refactorfrom
br/mui2/fix-ise
Feb 19, 2026
Merged

Fix IllegalStateException when opening a machine GUI#4661
jurrejelle merged 1 commit intomui2-refactorfrom
br/mui2/fix-ise

Conversation

@brachy84
Copy link

What

This happened because the circuit dialog was created outside the panel creation funcion with a .relative() setter which immediatly attached the panel to the main panel. But since the circuit panel is not open, it fails on resize.

Also replaced the fixed offset in the x pos with a relative value.

@brachy84 brachy84 requested a review from a team as a code owner February 19, 2026 08:50
@brachy84 brachy84 added type: bugfix General bug fixes 1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. labels Feb 19, 2026
@github-actions github-actions bot added the Tests: Passed Game Tests have passed on this PR label Feb 19, 2026
Copy link
Contributor

@jurrejelle jurrejelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for fixing, my goat

@jurrejelle jurrejelle merged commit 69b6b86 into mui2-refactor Feb 19, 2026
5 of 8 checks passed
@jurrejelle jurrejelle deleted the br/mui2/fix-ise branch February 19, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. Tests: Passed Game Tests have passed on this PR type: bugfix General bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants