fluid regulators now check that the correct amount of fluid was moved#4693
Merged
TarLaboratories merged 1 commit intoGregTechCEu:1.20.1from Feb 24, 2026
Merged
fluid regulators now check that the correct amount of fluid was moved#4693TarLaboratories merged 1 commit intoGregTechCEu:1.20.1from
TarLaboratories merged 1 commit intoGregTechCEu:1.20.1from
Conversation
TarLaboratories
added
type: bugfix
TarLaboratories
approved these changes
Feb 24, 2026
gustovafing
pushed a commit
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #4692
Implementation Details
This new check also does the same as the old check (that
insertableAmount > 0), becausesupplyAmount > 0is checked earlier in the methodHow Was This Tested
Tested the same way as to cause the bug
Also tested with multiple fluid types being moved (by using fluid buffers instead of drums with the same setup to cause the bug), the behavior is that each fluid type is treated independently, which is intended.